My favorite herring brine is as follows:
1 pack of frozen herring.
2 cups of rock salt.
1/2 cup of powdered milk or carnation instant creamer.
7 drops of green fool coloring.
Put all of the above contents in a tupperware container and place in refer or freezer.
Works good, last long time.
Good luck.